Start with python match statement
#1801
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuechA
requested review from
maximiliankaul,
lshala,
konradweiss and
oxisto
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
...anguage-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandler.kt
Outdated
Show resolved
Hide resolved
...anguage-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandler.kt
Outdated
Show resolved
Hide resolved
cpg-language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/Python.kt
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
...est/kotlin/de/fraunhofer/aisec/cpg/frontends/python/statementHandler/StatementHandlerTest.kt
Outdated
Show resolved
Hide resolved
...anguage-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandler.kt
Show resolved
Hide resolved
...anguage-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandler.kt
Outdated
Show resolved
Hide resolved
...anguage-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandler.kt
Outdated
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
...est/kotlin/de/fraunhofer/aisec/cpg/frontends/python/statementHandler/StatementHandlerTest.kt
Outdated
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
maximiliankaul
approved these changes
Nov 12, 2024
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Show resolved
Hide resolved
| * [Python.AST.match_case.body]. | ||
| * | ||
| * The [CaseStatement] is generated by the [Python.AST.match_case.pattern] and, if available, | ||
| * [Python.AST.match_case.guard]. If there's a `guard` present, we model the |
There was a problem hiding this comment.
"If there's a guard present, we model the... " this is a bit confusing. There is also a CaseStmt if there is no guard, isn't there?
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Outdated
Show resolved
Hide resolved
| } else { | ||
| newCaseStatement(rawNode = node).apply { | ||
| this.caseExpression = | ||
| node.guard?.let { |
There was a problem hiding this comment.
I don't like this style. I think a simple if / else if / else at the top level would be easier to read.
| newBinaryOperator(operatorCode = "===", rawNode = node).implicit().apply { | ||
| this.lhs = newReference(name = subject) | ||
| this.rhs = | ||
| when (val value = node.value) { |
There was a problem hiding this comment.
It feels like this should be an extra function (at least if we use this logic somewhere else, too). Have you seen easyConstant in the ExpressionHandler?.
We only expect True, False or None here according to the doc.
| } | ||
|
|
||
| @Test | ||
| fun testMatchAnd() { |
…ontends/python/StatementHandler.kt Co-authored-by: Maximilian Kaul <[email protected]>
Co-authored-by: Maximilian Kaul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the basic comparisons which can be found in python's
matchstatement. The statement is modeled as aSwitchStatementand the main issue are theCaseStatementswhich offer a wide range of checks, some of which we cannot model trivially.